Remove null from image field and add image into required for deployment container and init container #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @khtee , thanks for the contribution! All these schemas are automatically generated using this script https://github.com/yannh/openapi2jsonschema here: https://github.com/yannh/kubernetes-json-schema/blob/master/build.sh If you found an issue, it's likely a bug in the openapi2jsonschema script... any chance you could have a look? I would not merge "manual" changes to the generated schemas 😞 but happy to regenerate them if we can fix the script! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image is a required value when creating a deployment. Adding this check into schema to catch the error when there is no image field.
Following is the error received when performing
kubectl apply.